| 365 |
lars |
1 |
# PHPHtmlParser Contribution Guide
|
|
|
2 |
|
|
|
3 |
This page contains guidelines for contributing to the PHPHtmlParser package. Please review these guidelines before submitting any puLl requests to the package.
|
|
|
4 |
|
|
|
5 |
## Pull Requests
|
|
|
6 |
|
|
|
7 |
The pull request process differs for new features and bugs. Before sending a pull request for a new feature, you should first create an issue with `[Proposal]` in the title. The proposal should describe the new feature, as well as implementation ideas. The proposal will then be reviewed and either approved or denied. Once a proposal is approved, a pull request may be created implementing the new feature. Pull requests which do not follow this guideline will be closed immediately.
|
|
|
8 |
|
|
|
9 |
Pull requests for bugs may be sent without creating any proposal issue. If you believe that you know of a solution for a bug that has been filed on Github, please leave a comment detailing your proposed fix.
|
|
|
10 |
|
|
|
11 |
### Feature Requests
|
|
|
12 |
|
|
|
13 |
If you have an idea for a new feature you would like to see added to the package, you may create an issue on Github with `[Request]` in the title. The feature request will then be reviewed.
|
|
|
14 |
|
|
|
15 |
## Coding Guidelines
|
|
|
16 |
|
|
|
17 |
We follow the [PSR-0](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md) autoloading standard and take heavily from the [PSR-1](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md) coding standards. In addition to these standards, below is a list of other coding standards that should be followed:
|
|
|
18 |
|
|
|
19 |
- Class opening `{` should be on the same line as the class name.
|
|
|
20 |
- Function and control structure opening `{` should be on a separate line.
|
|
|
21 |
- Interface names are suffixed with `Interface` (`FooInterface`)
|